On 10/20/2013 03:56 PM, Samuel Thibault wrote: > This patchs adds parameters to manage some new options in the qemu -net > command. > Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in > argument to the qemu command. > Defaults parameters are respectively fc00::1, fc00::, /64 and fc00::2. > > Signed-off-by: Yann Bordenave <m...@meowstars.org> > ---
Just focusing on interface for now... > +++ b/qapi-schema.json > @@ -2807,6 +2807,12 @@ > # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP option > # to the guest > # > +# @ip6_prefix: #optional IPv6 network prefix Please mention '(since 1.8)' for each new field. Also, this command doesn't have any '_', so your new field names should be named with '-', as in @ip6-prefix > +# > +# @ip6_host: guest-visible IPv6 address of the host > +# > +# @ip6_dns: guest-visible IPv6 address of the virtual nameserver > +# > # @smb: #optional root directory of the built-in SMB server > # > # @smbserver: #optional IP address of the built-in SMB server > @@ -2820,20 +2826,23 @@ > ## > + '*ip6_prefix': 'str', Why is this a str instead of an integer? > + '*ip6_host': 'str', > + '*ip6_dns': 'str', These look okay (other than the - vs _ issue) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature