> > Keep the name then. The new name is misleading. ok.
>>>> Totally synchronous, >>>> and guarantees that a given function will be executed at the specified >>>> vcpu. >>>> >>>> This patch also convert usage within the breakpoints system >>>> >>>> +void qemu_queue_work(CPUState *env, void (*func)(void *data), void >>>> *data); >>>> >>>> >>> >>> The name suggests that it is asynchronous. >>> >>> Why is this patch necessary? >>> >> >> to keep gdbstub working. >> > > "Because it fixes things". > > Please elaborate. > gdbstub is called from the i/o thread , and call vcpu ioctls. So it has to use the on_vcpu mechanism to guarantee its execution in the right thread. What I meant is that currently, gdbstub is the only user of it, at least in qemu.git -- Glauber Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act."