On 27/10/2013 20:37, Gabriel Kerneis wrote:
On Sun, Oct 27, 2013 at 04:23:54PM +0100, Charlie Shepherd wrote:
These patches were the first two from my GSoC series and were reasonably
straight-forward and well accepted. Gabriel and I are hoping the patches from
GSoC can be merged before I start my job in December, so I'm starting by sending
the simple parts of the overall patchset, when they are merged then I will redo
the later parts in several smaller and more manageable patchsets.
The patches look good, I just reviewed them again. They cannot be applied
because you forgot --signoff.
Also, I think it would be more consistent if you added the following patches in
the same series:
- add blocking_fn (I sent it to qemu-devel some time ago),
- protect coroutine_fn and blocking_fn definition with #ifndef (to allow
redefining them easily on the command line with extra cflags).
Could you resend the series with these suggestions?
Good points, thanks, resent with your suggested changes.
Charlie
