On 11/08/2013 03:19 AM, Fam Zheng wrote: > >> + BlockDriverState *bs; >> + BlockDriver *drv; >> + char fbuf[1024]; > > Could use PATH_MAX.
PATH_MAX is undefined on some platforms, and could also be defined to something larger than a page which could lead to nastiness if you end up overflowing the stack. I personally prefer malloc'd buffers rather than attempting to guess at how large to size things, although the rest of the code base also has similar caps at 1024 so this isn't making it worse. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
