On 11/08/13 18:15, Paolo Bonzini wrote: > Il 08/11/2013 18:09, Andreas Färber ha scritto: >> I don't have personal experience with using external files there yet, >> but I was hoping that using -pflash pc-bios/bios.bin would just work >> since that'll be symlinked for execution from build directory iiuc. >> >> My thinking was the test could then verify that the BIOS does not read >> as all 0xff, whereas Paolo's suggestion sounds more elaborate, ruling >> out actual 0xff within SeaBIOS by having a positive pattern to check for. > > Yeah, that's also a good test and easier!
Believe it or not, I did think of both 0x00..0xFF (from a small static file) and using an actual bios image :) I think I'd prefer 0x00..0xFF (with a temporary file as Paolo suggested) because "what is it" looks more attractive than "what is it not" to me. Also, opening the packaged bios binary from the build dir would need extra symlinking again; mkstemp() seems cleaner. Thanks! Laszlo
