On 11/15/2013 09:22 AM, lijun wrote: > From: Jun Li <junm...@gmail.com> > > Hi all, > > snapshot_blkdev can not consider //root/sn1 and /root/sn1 as the same > file. When file /root/sn1 is the base file, do snapshot using file > //root/sn1, qemu consider it as a new file. So this will rewrite the > base file.
Careful. On cygwin, /root and //root are two different files (and POSIX
allows this). While qemu hasn't yet been ported to cygwin, we should
not make the task harder by using incorrect ad-hoc normalization.
> + /* Delete duplicate '/' in filename. */
> + while (*p != '\0') {
Rather than hand-rolling a loop, you should use realpath() (guaranteed
by POSIX, but not always portable) or its appropriate glib wrapper,
where we can assume that glib will properly account for // being
distinct on platforms where it matters.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
