On Mon, Nov 18, 2013 at 05:54:33PM +0100, Andreas Färber wrote: > Am 18.11.2013 17:48, schrieb Stefan Hajnoczi: > > On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: > >> This avoids each test needing to add it to suppress windows popping up. > >> > >> Signed-off-by: Andreas Färber <afaer...@suse.de> > >> --- > >> tests/boot-order-test.c | 2 +- > >> tests/endianness-test.c | 6 +++--- > >> tests/fw_cfg-test.c | 3 +-- > >> tests/hd-geo-test.c | 2 +- > >> tests/i440fx-test.c | 2 +- > >> tests/libqtest.c | 1 + > >> tests/m48t59-test.c | 2 +- > >> tests/qom-test.c | 2 +- > >> tests/rtc-test.c | 2 +- > >> tests/tmp105-test.c | 2 +- > >> 10 files changed, 12 insertions(+), 12 deletions(-) > > > > I avoided making -display none common because tests may wish to have a > > display. But at the moment no test needs a display so I guess this is > > fine. > > I was under the assumption that -display none -display sdl would work > just like mst's overriding the default -machine accel=qtest with > -machine accel=tcg?
Good point. I checked the code and it works. Let's take your patch since it also prevents future problems. Stefan
