On Tue, Nov 26, 2013 at 6:41 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 26/11/2013 11:31, Fam Zheng ha scritto: >>> > I would just use an uint64_t, I think you have ~20 operations now. >>> > There is still quite some breathing room. >>> > >> OK. Then, can we still use QAPI enum? Because I think being possible >> to query blockers makes sense, that way the user doesn't have to trial >> and error to know what operation is blocked. > > Yes, we can. You would still have to add a bunch of > > #define BLOCK_OPERATION_MASK_RESIZE (1ULL << BLOCK_OPERATION_TYPE_RESIZE) > > in block.h. >
Well that works, but then we have a repeated list of operations in two places, I'm not sure that would be good to have. Kevin, Stefan, any opinion? Fam
