Re: [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK version 3

[Paolo Bonzini]

Il 27/11/2013 03:06, Fam Zheng ha scritto:
> +    } else if (le32_to_cpu(header.version) == 3 && flags & BDRV_O_RDWR) {

Parentheses around "flags & BDRV_O_RDWR", please.

I'll try to patch checkpatch.pl to flag this.

Paolo

> +        error_setg(errp, "VMDK version 3 must be read only");
> +        return -EINVAL;
>      }