Am 28.11.2013 um 18:57 hat Eric Blake geschrieben: > On 11/28/2013 07:49 AM, Kevin Wolf wrote: > > >>>>> https://github.com/famz/qemu.git 035-filter-qemu-io > >>>>> > >>>>> v2: Rebase to current master. > >>>>> [01] Add Reviewed-by for Eric. > >>>>> [02] Update comment to describe the command for mechanical > >>>>> substitution. (Eric) > >>>> > >>>> Kevin, would you like to take this one? > >>> > >>> I would, but this way it simply doesn't work. > >>> > >>> The '035-filter-qemu-io' branch in your repo is something, but certainly > >>> not this series. It may be some early RFC where you only fixed one case. > >>> I then found the 'iotests-filter-qemu-io' (which is already not what you > >>> said) branch and I almost would have applied it, but I noticed it's not > >>> exactly the same as this series; I suppose it's version 1. > >>> > >>> Eric reviewed _something_, but the two branches I found aren't what you > >>> sent, and he didn't specify the commit ID he reviewed, so I can't put > >>> his Reviewed-by tag anywhere, because I simply don't know what he looked > >>> at. > > And I've since lost track of which commit id I reviewed. > > >>> > >>> Fam, can you push the _current_ version somewhere and tell me the > >>> correct branch name and commit ID? Eric, can you then tell me if this > >>> newly pushed code matches what you reviewed? > >> > >> Sorry, I've pushed again to: > >> > >> https://github.com/famz/qemu.git for-kevin > >> > >> Please fetch again. > > > > Thanks, cherry-picked the patches from that branch (commit ID of the > > top is 0974950e05137c7751ec1d3c5d1b0fa5387eead9). I didn't add Eric's > > Reviewed-by yet, but I'll do so when he confirms that this is what he > > checked. > > I have now reviewed commit 0974950e05137c7751ec1d3c5d1b0fa5387eead9 in > the same manner as before (manually followed the 'sed' instructions in > the commit message and verified that the only differences remaining are > the added filter). It appears that the only differences in this known > commit id from whatever (now unknown) commit I first reviewed is thus > limited to rebase differences. I'm happy with the commit, so feel free > to (re-)add: > > Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks, Eric, I've added it back now. Kevin
pgpLiLDTOhcfa.pgp
Description: PGP signature