Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: > On 12/03/2013 09:09 AM, Andreas Färber wrote: >> Am 02.12.2013 18:06, schrieb Michael Tokarev: >>> 25.11.2013 07:39, Alexey Kardashevskiy wrote: >>>> Since modern POWER7/POWER8 chips can have more that 256 CPU threads >>>> (>2000 actually), remove this check from smp_parse. >>>> >>>> The CPUs number is still checked against machine->max_cpus and this check >>>> should be enough not to break other archs. >> >> "should be" is not exactly the highest level of confidence for a >> "trivial" patch... :/ [...] >> Alexey, did you actually check that, e.g., x86 machines don't break with >> 256 or 257 CPUs now? > > PC_DEFAULT_MACHINE_OPTIONS sets it to 255. And I cannot find any machine > which would not define max_cpus, have I missed any?
If you've actually *checked* the other machines' code then fine with me, just say so in the commit message. :) Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg