On 5 December 2013 02:33, Li Guang <lig.f...@cn.fujitsu.com> wrote: > Peter Crosthwaite wrote: >> >> Hi Liguang, >> >> V9 has some checkpatch errors: >> >> [pcrost@xsjandreislx qemu]$ git format-patch HEAD~5 >> 0001-vmstate-add-VMSTATE_PTIMER_ARRAY.patch >> 0002-hw-timer-add-allwinner-a10-timer.patch >> 0003-hw-intc-add-allwinner-A10-interrupt-controller.patch >> 0004-hw-arm-add-allwinner-a10-SoC-support.patch >> 0005-hw-arm-add-cubieboard-support.patch >> [pcrost@xsjandreislx qemu]$ ./scripts/checkpatch.pl 00* >> ERROR: need consistent spacing around '*' (ctx:WxB) >> #30: FILE: include/migration/vmstate.h:618: >> + VMSTATE_ARRAY_OF_POINTER(_f, _s, _n, 0, vmstate_info_ptimer, >> ptimer_state *)
> the error here seems subtle, > 2 rules used, > 1. should a space both before and after '*' > 2. shouldn't a space before ')' Yes, sometimes checkpatch gets confused by macros, especially ones like this whose arguments might be types. The correct spacing here I think would be to have no space before or after the '*'. thanks -- PMM