Paolo Bonzini <pbonz...@redhat.com> writes: > Il 05/12/2013 10:44, Markus Armbruster ha scritto: >> Incompatible change: device ide-cd moved to a different controller. > > Yes, it should be stated in the commit message but it's expected as > discussed yesterday on IRC. The solution is not to use "-device" (which > was broken) if you care about backwards compatibility; use "-drive if=ide".
-device is broken for the *other* controller. It works just fine for this one. >> Great fun when you try to live migrate across your patch. >> >> I'd expect isapc to have the same issue once its crash bug is fixed. >> >> First law of QEMU hacking: if your patch looks simple, it's probably >> wrong ;) > > Yes, the question is how wrong and how the wrong balances the right. Is it really too much bother to change the ide.0 name for the controllers that bus=ide.0 doesn't use, and keep it for the one it does use? If yes, the incompatible change needs to be documented much more clearly in the commit message.
