Re: [Qemu-devel] [PATCH 1/4] memory: cache min/max_access_size

[Uri Lublin]

On 12/02/2013 04:40 PM, Paolo Bonzini wrote:

This will simplify the code in the next patch.

Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
  include/exec/memory.h |  2 ++
  memory.c              | 27 +++++++++++----------------
  2 files changed, 13 insertions(+), 16 deletions(-)

typedef struct MemoryListener MemoryListener;

diff --git a/memory.c b/memory.c
index 28f6449..56e54aa 100644
--- a/memory.c
+++ b/memory.c
@@ -443,8 +443,6 @@ static void memory_region_write_accessor(MemoryRegion *mr,
  static void access_with_adjusted_size(hwaddr addr,
                                        uint64_t *value,
                                        unsigned size,
-                                      unsigned access_size_min,
-                                      unsigned access_size_max,
                                        void (*access)(MemoryRegion *mr,
                                                       hwaddr addr,
                                                       uint64_t *value,
@@ -457,15 +455,8 @@ static void access_with_adjusted_size(hwaddr addr,
      unsigned access_size;
      unsigned i;

- if (!access_size_min) {

-        access_size_min = 1;
-    }
-    if (!access_size_max) {
-        access_size_max = 4;
-    }
-
      /* FIXME: support unaligned access? */
-    access_size = MAX(MIN(size, access_size_max), access_size_min);
+    access_size = MAX(MIN(size, mr->min_access_size), mr->min_access_size);

Hi Paolo,

Here it should be                       mr->max_access_size

[ btw, MAX(MIN(a,b), b) = b ]

Regards,
    Uri.