Gerd Hoffmann <kra...@redhat.com> writes: > Hi, > > Qemu creates a bunch of default devices (serial, parallel, vga, ...) if > the user didn't specify one on the command line. Unfortunaly this > doesn't work well with the qdev way of doing things because this logic > is tied to the -serial, -parallel, ... command line switches. Devices > created via -device are ignored. This patch set fixes this. It also > adds a command line switch to disable all default devices and does a few > cleanups in the code touched anyway. > > New in v3: Rebased against latest master. Two patches (qmp monitor + > s390 console) came into the way. Because the way how serial lines and > the monitor are initialized changes quite heavily it looked alot cleaner > to me just revert those patches, apply the v2 patches, then reimplement > the two patches on top of that. > > New in v4: > * Rebased against latest master. > * Moved the included fixes from (yesterdays) staging to the head > of this series. > * Fixed segfault without -monitor switch. > * Killed noisy debug leftover. > * Replaced fprintf("fixme") with a real error message. > * Better commit messages for the monitor changes. > * Killed the #ifdef for s390 virtio console. > > Luiz + Alex, please have a closer look at this. > > http://repo.or.cz/w/qemu/kraxel.git/shortlog/refs/heads/default.v4 > > thanks, > Gerd
Series looks good to me, my nitpicking on some of its parts notwithstanding. Without it, chardev entries in configuration files are broken, -device doesn't work for the first serial, parallel, NIC, and -drive doesn't work for first CD-ROM, floppy or SD. These are important fixes, so please consider for 0.12.