Kirill A. Shutemov wrote: > Currently we have few issues with P9_STATS_GEN: > > - We don't try to read st_gen anything except files or directories, but > still set P9_STATS_GEN bit in st_result_mask. It may mislead client: > we present garbage as valid st_gen. > > - If we failed to get valid st_gen with ENOTTY, we ignore error, but > still set P9_STATS_GEN bit in st_result_mask. > > - If we failed to get valid st_gen with any other errno, we fail > getattr altogether. It's excessive: we block valid client use-cases, > like chdir(2) to non-readable directory with execution bit set. > > The patch fixes these issues and cleanup code a bit. > > Signed-off-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com> > Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > Reviewed-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com>
Ping? -- Kirill A. Shutemov
