On 12/11/2013 05:19 AM, Paolo Bonzini wrote: > From: Wanlong Gao <gaowanl...@cn.fujitsu.com> > > Signed-off-by: Wanlong Gao <gaowanl...@cn.fujitsu.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > ---
> +++ b/qapi-schema.json
> @@ -4235,3 +4235,33 @@
> # Since: 1.7
> ##
> { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } }
> +
> +##
> +# @NumaOptions
> +#
> +# A discriminated record of NUMA options. (for OptsVisitor)
> +#
> +# Since 2.0
> +##
> +{ 'union': 'NumaOptions',
> + 'data': {
> + 'node': 'NumaNodeOptions' }}
Why do we need a union, if there's no alternative, and since nothing
else in the series adds an alternative?
> +
> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node. (for OptsVisitor)
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @cpus: #optional VCPUs belong to this node
What are the defaults if these fields are omitted?
> +#
> +# @mem: #optional memory size of this node
In bytes? Why is this field a string instead of an integer?
> +#
> +# Since: 2.0
> +##
> +{ 'type': 'NumaNodeOptions',
> + 'data': {
> + '*nodeid': 'uint16',
> + '*cpus': ['uint16'],
> + '*mem': 'str' }}
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
