Am 12.12.2013 um 09:23 hat Fam Zheng geschrieben: > This adds the enum of all the operations that can be taken on a block > device. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > qapi-schema.json | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index d6f8615..ef4d6af 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1440,6 +1440,55 @@ > 'data': ['commit', 'stream', 'mirror', 'backup'] } > > ## > +# @BlockOperationType > +# Type of a block operation. (since 1.8)
I don't think this description is accurate any more. You now have a list of roles that a block device can take, or something like that. Not sure what the best way to put it is. backup-source isn't an operation anyway, nor is dataplane. Also, should have an empty line after @BlockOperationType and 2.0 instead of 1.8. > +# @backup-source: As a backup source. See the 'drive-backup' command. > +# > +# @backup-target: As a backup target. See the 'drive-backup' command. > +# > +# @change: See the 'change' command. > +# > +# @commit: See the 'block-commit' command. > +# > +# @dataplane: The virtio-blk dataplane feature. > +# > +# @drive-del: See the 'drive_del' HMP command. > +# > +# @eject: See the 'eject' command. > +# > +# @external-snapshot: See the 'blockdev-snapshot-sync' command. > +# > +# @internal-snapshot: See the 'blockdev-snapshot-internal-sync' command. > +# > +# @internal-snapshot-delete: See the > 'blockdev-snapshot-delete-internal-sync' command. > +# > +# @mirror: See the 'drive-mirror' command. > +# > +# @resize: See the 'block-resize' command. > +# > +# @stream: See the 'block-stream' command. > +# > +# Since: 1.8 Here as well. Kevin