Am 14.12.2013 07:53, schrieb Peter Crosthwaite: > On Fri, Dec 13, 2013 at 10:44 PM, Igor Mammedov <imamm...@redhat.com> wrote: >> From: Hervé Poussineau <hpous...@reactos.org> >> >> We should not modify the type hash table while it is being iterated on. >> Assert that it does not happen. >> >> Signed-off-by: Hervé Poussineau <hpous...@reactos.org> >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> Signed-off-by: Igor Mammedov <imamm...@redhat.com> >> --- >> v2: >> * make ver more descriptinve s/enumerating/enumerating_classes/ >> [asked-by: Peter Crosthwaite] >> --- >> qom/object.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/qom/object.c b/qom/object.c >> index 3a43186..4a0fb86 100644 >> --- a/qom/object.c >> +++ b/qom/object.c >> @@ -78,8 +78,10 @@ static GHashTable *type_table_get(void) >> return type_table; >> } >> >> +static bool enumerating_classes = false; > > This seems to be a change in terminology i.e. s/type/class. Should it > be enumerating_types or enumerating_type_table?
Too many cooks... While offline, I picked up the original version, changing to enumerating_types, which Alexey also happened to choose, and then adopted his drop of "false" assignment. > Also blank line here between global var decl and fn. Same thought here, already did in my version. :) > Otherwise, > > Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> Thanks, will update while rebasing. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
