On 12/21/2013 08:43 AM, Aurelien Jarno wrote: > P_REXW is defined has a constant at the beginning of i386/tcg-target.c, > but the corresponding bit is later used in a harcoded way, which defeat > the purpose of a constant. > > Fix that by using a conditional expression operator instead of a shift. > On x86 this actually makes the code slightly smaller as GCC does in > practice (opc >> 8) & 8 instead of (opc & 0x800) >> 8 so the constants > are smaller to load. > > Signed-off-by: Aurelien Jarno <aurel...@aurel32.net> > --- > tcg/i386/tcg-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <r...@twiddle.net> r~
