On Fri, Jan 3, 2014 at 1:01 PM, Kewei Yu <kewe...@gmail.com> wrote: > > 2014/1/2 Andreas Färber <afaer...@suse.de> >> >> Am 01.01.2014 05:40, schrieb Peter Crosthwaite: >> > On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu <kewe...@gmail.com> wrote: >> >> 2013/12/31 Peter Crosthwaite <peter.crosthwa...@xilinx.com> >> >>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu <kewe...@gmail.com> wrote: >> >>>> When we disabling vnc from "./configure", the qemu can't use the vnc >> >>>> option. >> [...] >> >>>> So qtest can't use the "vnc -none ", otherwise "make check" will >> >>>> hang. >> >>> >> >>> Curious, why exactly does make check hang? Shouldn't it just fail with >> >>> an error result in this case? >> >> >> >> Yeah, there is an error result "VNC support is disabled". >> > >> > I think its just terminology then. s/hangs/fails. >> >> Actually no. When qtest gets an unsupported command line argument, so >> that QEMU exits right away, then qtest hangs, waiting for the process. >> This was easily reproducible by mistyping machine names in my qom-test. >> That's a separate issue though. > > Yeah, It actually waits for the a handler and doesn't exit from "make > check". > Maybe I didn't show a detailed description. > So, Should I submit the patch v4?
Probably not just for this. "fails" is fine. Regards, Peter >> >> >> Regards, >> Andreas >> >> -- >> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany >> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg > >