Ok. I did not include those modifications into the patch in order to avoid modifications to the TAP netdev.
2014/1/13 Stefan Hajnoczi <stefa...@gmail.com> > On Fri, Dec 13, 2013 at 01:04:59PM +0100, Vincenzo Maffione wrote: > > diff --git a/include/net/net.h b/include/net/net.h > > index 11e1468..f5b5bae 100644 > > --- a/include/net/net.h > > +++ b/include/net/net.h > > @@ -50,6 +50,12 @@ typedef void (NetCleanup) (NetClientState *); > > typedef void (LinkStatusChanged)(NetClientState *); > > typedef void (NetClientDestructor)(NetClientState *); > > typedef RxFilterInfo *(QueryRxFilter)(NetClientState *); > > +typedef bool (HasUfo)(NetClientState *); > > +typedef int (HasVnetHdr)(NetClientState *); > > Please change the return type to bool. bool is easier to understand > since the reader can be sure the variable only takes true/false values. > > > +typedef int (HasVnetHdrLen)(NetClientState *, int); > > Please change the return type to bool. > -- Vincenzo Maffione
