On Mon, Jan 27, 2014 at 11:48:11AM +0800, Fam Zheng wrote: > + pstrcpy(bs->backing_file, sizeof(bs->backing_file), > backing_hd->filename); > + pstrcpy(bs->backing_format, sizeof(bs->backing_file), > + backing_hd->drv ? backing_hd->drv->format_name : ""); > + bdrv_ref(bs->backing_hd); > + > + pstrcpy(bs->backing_file, sizeof(bs->backing_file), > + bs->backing_hd->file->filename); > + pstrcpy(bs->backing_format, sizeof(bs->backing_format), > + bs->backing_hd->drv->format_name);
This is redundant, you already have the same above?