On 01/30/2014 07:12 AM, Paolo Bonzini wrote: > Il 30/01/2014 15:09, Eric Blake ha scritto: > | Also, I like how your int printout was both decimal and hex; but > | here you are throwing away information (and the bigger the number, > | the more we lose as to how much got rounded away). I'd rather see > | this as: > | > | "%0.03f%c (%llu)" > | > | so that we also have access to the unrounded exact amount. > > Perhaps the other way round (since hex is in parentheses)?
Indeed, exact(human) is better than human(exact). > > This patch is just moving the code from qdev-properties.c. I agree > with all your suggestion, but I'd prefer to tackle it as follow-ups or > as patch 13/12. There are other problems, like 512MB printed as > 0.500G (which is correct but looks weird). Sure - if you post 13/12, then I'm fine with this one having: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
