On Fri, Jan 31, 2014 at 10:20:42AM -0700, Eric Blake wrote: > On 01/31/2014 09:49 AM, Martin Kletzander wrote: > > Introduce 'query-chardev-backends' QMP command which lists all > > supported character device backends. > > > > Signed-off-by: Martin Kletzander <mklet...@redhat.com> > > --- > > v2: > > - Version changed from "1.8.0" to "2.0" > > > > qapi-schema.json | 22 ++++++++++++++++++++++ > > qemu-char.c | 19 +++++++++++++++++++ > > qmp-commands.hx | 41 +++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 82 insertions(+) > > > + > > +-> { "execute": "query-chardev-backends" } > > +<- { > > + "return":[ > > + { > > + "name":"udp", > > + }, > > Sorry for not noticing earlier, but this is not valid JSON. Lose the > trailing comma after each "name":"value", since the last element in a > JSON struct is not permitted to have a comma. >
At first, I had it as a list of strings, maybe that's why I left it there by mistake, hopefully v3 will be OK. Thanks for the review, Martin > > + { > > + "name":"tcp", > > + }, > > + { > > + "name":"unix", > > + }, > > + { > > + "name":"spiceport", > > + } > > With that change to all four spots, > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
signature.asc
Description: Digital signature