On Mon, Jan 20, 2014 at 06:07:03PM +0100, Vincenzo Maffione wrote:
> The TAP NetClientInfo structure is inizialized with the TAP-specific
> functions that manipulates offloading features.
>
> Signed-off-by: Vincenzo Maffione <v.maffi...@gmail.com>
> ---
> net/tap.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/tap.c b/net/tap.c
> index c805f3c..d34ec88 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -314,6 +314,12 @@ static NetClientInfo net_tap_info = {
> .receive_iov = tap_receive_iov,
> .poll = tap_poll,
> .cleanup = tap_cleanup,
> + .has_ufo = tap_has_ufo,
> + .has_vnet_hdr = tap_has_vnet_hdr,
> + .has_vnet_hdr_len = tap_has_vnet_hdr_len,
> + .using_vnet_hdr = tap_using_vnet_hdr,
> + .set_offload = tap_set_offload,
> + .set_vnet_hdr_len = tap_set_vnet_hdr_len,
> };
>
> static TAPState *net_tap_fd_init(NetClientState *peer,
Please make these tap_*() functions static. They do not need to be
accessed from outside this source file.
I also noticed that you didn't touch tap-win32.c. I guess it should
also assign its tap_has_ufo() and similar functions. (tap-win32.c
declares its own net_tap_info struct.) Here, we can also make the
functions static.
