On 8 February 2014 04:40, Fam Zheng <f...@redhat.com> wrote: > This adds parameter "argv0" in calling path from main() to > module_call_init(). So that module loader knows the location of > executable.
This patch looks kind of odd to me. Why are there so many different places calling module_call_init() and passing in an argv0? I would have expected that vl.c (and the equivalent main functions for the tools) would just initialise the module system once, passing in the argv0 at that point. It's not obvious why the block layer should be handing argv0 around through bdrv_init in order to (re-?) initialise modules. linux-user and bsd-user should probably force "don't ever build with loadable modules" if we don't do that already. -- PMM
