Am 09.02.2014 02:53, schrieb Peter Crosthwaite: > On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber <afaer...@suse.de> wrote: >> Use type-specific QOM cast macros instead. >> > > Should be past tense - "We now use type-specific ...". The imperative > form of "use" suggests you are making the change in this patch but you > have already done it.
It was meant as a guidance for resolving conflicts due to lack of that macro, not as a description of past patches. I've adopted your wording. >> Signed-off-by: Andreas Färber <afaer...@suse.de> > > Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
