On 09/02/14 15:10, Andreas Färber wrote:
Hi Andreas,
Hi,
Am 08.02.2014 17:38, schrieb Mark Cave-Ayland:
+static Property cg3_properties[] = {
+ DEFINE_PROP_HEX32("vram_size", CG3State, vram_size, -1),
Paolo is about to drop hex32 ...
Hmmmm okay...
+ DEFINE_PROP_UINT16("width", CG3State, width, -1),
+ DEFINE_PROP_UINT16("height", CG3State, height, -1),
+ DEFINE_PROP_UINT16("depth", CG3State, depth, -1),
+ DEFINE_PROP_HEX64("prom_addr", CG3State, prom_addr, -1),
...and hex64 types. Please use UINT32 and UINT64 instead.
Alright I can change those for the next version of the patch. Does that
mean the use of hex output is now a display option rather than a
separate property type?
+ DEFINE_PROP_END_OF_LIST(),
+};
And as far as QOM and style is concerned, please don't use TCX as excuse
to do things the old way. If you feel you need consistency, feel free to
clean up TCX, but we only require it for new patches. Otherwise no
progress would be possible within the code base.
Okay, I understand this. I'm highly tempted to submit a clean-up patch
for TCX too when this is complete just to keep both drivers in a similar
state.
One thing I'm not sure about is how the QOM stuff interacts with sysbus
- can you quickly point me towards an existing device that does this so
I can understand how this works? These patches have been around for
months and I really want to get them in for QEMU 2.0 if freeze is coming
up soon.
Many thanks,
Mark.
