On Mon, Feb 10, 2014 at 10:49:35PM -0800, Peter Crosthwaite wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. > > Signed-off-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> > ---
Reviewed-by: Martin Kletzander <mklet...@redhat.com>
With this patch qemu doesn't crash in my use-case.
>
> hw/char/serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/char/serial.c b/hw/char/serial.c
> index 27dab7d..6d3b5af 100644
> --- a/hw/char/serial.c
> +++ b/hw/char/serial.c
> @@ -225,7 +225,7 @@ static gboolean serial_xmit(GIOChannel *chan,
> GIOCondition cond, void *opaque)
>
> if (s->tsr_retry <= 0) {
> if (s->fcr & UART_FCR_FE) {
> - s->tsr = fifo8_is_full(&s->xmit_fifo) ?
> + s->tsr = fifo8_is_empty(&s->xmit_fifo) ?
> 0 : fifo8_pop(&s->xmit_fifo);
> if (!s->xmit_fifo.num) {
> s->lsr |= UART_LSR_THRE;
> --
> 1.8.5.4
>
signature.asc
Description: Digital signature
