On Thu, Feb 20, 2014 at 7:35 AM, Paolo Bonzini <pbonz...@redhat.com> wrote: > Looks like _ is more common than - for device properties: > > $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l > 132 > $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l > 77
And more locally, "scsi-id" in scsi-bus.c is the only property in hw/scsi with a '-'. scsi-disk.c already has "max_unmap_size" and megasas.c has several '_' already. With that said I'm fine either way, and if you want to munge my patch to use '-' that's perfectly OK with me. Or I'm happy to resubmit in the other form. - R.
