On Fri, Feb 21, 2014 at 10:07 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 20 February 2014 23:58, Alistair Francis <alistair.fran...@xilinx.com> > wrote: >> On Fri, Feb 21, 2014 at 1:44 AM, Peter Maydell <peter.mayd...@linaro.org> >> wrote: >>> This breaks compilation of the arm-linux-user target >>> (the qemu_clock_get_* functions are only available in >>> system mode). You probably want to do something similar >>> to how we handle the generic timers, where we #ifdef >>> everything out. (I don't think Linux gives user >>> space access to the perf monitor registers.) > >> What do you think the functions should do when in user space? Should >> they just return 0? > > Just don't define reginfo entries for them at all -- then we will > UNDEF because the lookup will return no result. This is what > the generic timer code does. > > thanks > -- PMM >
Ok, so if it is user mode, it just treats the pmccntr register exactly as it does before the patch. I've implemented that and it seems to work. I'll submit the patch now