On Thu, Feb 20, 2014 at 03:40:43PM +0100, Vincenzo Maffione wrote: > This patch fixes configure so that the netmap backend is not compiled in if > the > host doesn't support an API version >= 11. A version upper bound (15) has been > added so that the netmap API can be extended with some minor features without > requiring QEMU code modifications. > > Moreover, some changes have been done to net/netmap.c in order to reflect the > current netmap API/ABI (11). > > The NETMAP_WITH_LIBS macro makes possible to include some utilities (e.g. > netmap ring macros, D(), RD() and other high level functions) through the > netmap > headers. In this way we get rid of the D and RD macro definitions in the QEMU > code, and we open the way for further code simplifications that will be > introduced by future patches. > > Signed-off-by: Vincenzo Maffione <v.maffi...@gmail.com> > --- > Note: This patch is against the net-next/net Stefan's branch. > > Changes against the previous version: > (1) more complete commit description > (2) add comment in ./configure to explain version checks > > configure | 10 +++++++++- > net/netmap.c | 55 +++++++++++++------------------------------------------ > 2 files changed, 22 insertions(+), 43 deletions(-)
Thanks for adding the explanations, it will make it easier for people reading the code to understand this change in the future. Applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan