On 26 February 2014 09:25, Xuebing Wang <xbi...@gmail.com> wrote: > This patch does below: > - Move the declaration of 2 translate functions from translate-all.h into > include/exec/exec-all.h > - remove file translate-all.h > > "translate-all.h" => "exec/exec-all.h" can be done by: > git grep -w "translate-all.h" | cut -d: -f1 | > xargs sed -i 's/\<translate-all.h\>/exec\/exec-all.h/g' > > Note: > 1) "exact whole word match" is considered. > 2) We may move translate related from include/exec/exec-all.h into > include/exec/translate.h later.
Is there any particular benefit to this change? The function prototypes go from being in a header only included by the file that uses them to being in a header that's included by a lot of other code... thanks -- PMM