On 03.03.2014 13:59, Paolo Bonzini wrote:
Il 03/03/2014 12:20, Peter Lieven ha scritto:
This #ifdef should be in the raw-posix driver. Please try to keep the
qemu interface backend agnostic and leave POSIX_FADV_DONTNEED and
friends as an implementation detail of block drivers.
I had the same idee, but as far as I see the callback to the completes
request is handled in block.c. raw-posix uses the aio interface and
not coroutines.
You can put it in the QEMU_AIO_READ case of aio_worker.
Thanks for the pointer.
linux-aio.c is only for O_DIRECT, so you do not need it there.
BTW, perhaps you need to exclude the fadvise if O_DIRECT is in use?
Good point!
Paolo
Peter
