The Tuesday 04 Mar 2014 à 10:35:48 (-0500), Jeff Cody wrote :
> Originally, this built up the error message with the backing filename,
> so that errp was set as follows:
> error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename);
>
> However, we now propagate the local_error from the
> bdrv_open_backing_file() call instead, making these 2 lines useless
> code.
>
> Signed-off-by: Jeff Cody <jc...@redhat.com>
> ---
> block/mirror.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> index e683959..dd5ee05 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -520,9 +520,6 @@ static void mirror_complete(BlockJob *job, Error **errp)
>
> ret = bdrv_open_backing_file(s->target, NULL, &local_err);
> if (ret < 0) {
> - char backing_filename[PATH_MAX];
> - bdrv_get_full_backing_filename(s->target, backing_filename,
> - sizeof(backing_filename));
> error_propagate(errp, local_err);
> return;
> }
> --
> 1.8.3.1
>
>
Reviewed-by: Benoit Canet <ben...@irqsave.net>