On 05.03.2014 17:52, Eric Blake wrote:
On 03/03/2014 08:28 AM, Max Reitz wrote:
This function joins two QDicts by absorbing one into the other.

Signed-off-by: Max Reitz <mre...@redhat.com>
---
  include/qapi/qmp/qdict.h |  3 +++
  qobject/qdict.c          | 32 ++++++++++++++++++++++++++++++++
  2 files changed, 35 insertions(+)

Reviewed-by: Eric Blake <ebl...@redhat.com>

However, I think you should expand the testsuite to cover this addition
(can be a followup)

I keep forgetting the tests for QDict... Yes, I'll include it in v2.


Thanks,

Max

Reply via email to