On 06.03.2014 13:57, Kevin Wolf wrote:
Am 05.03.2014 um 22:41 hat Max Reitz geschrieben:
The "file" protocol drivers (block/raw-posix and block/raw-win32) may be
explicitly selected by prepending a "file:" prefix to a filename (as
with all other block protocols). However, currently, they do not strip
this prefix as they should.
This series fixes this issue.
Thanks, applied to the block branch.
This is just for consistency and there is no real use case for this,
right? If so, it would be even more consistent to do the same for the
host_* drivers provided by block/raw-{posix,win32}.c
The use case would be that this allows explicitly specifying the prefix
in order to create image files with a colon ("file:foo:bar.qcow2" for an
image named "foo:bar.qcow2", although "./foo:bar.qcow2" works just as well).
I only looked for the "file" protocol drivers, but I'll have a look for
other protocol drivers which currently do not strip their prefix as well
(such as host_*, yes).
I talked about this multiple times in discussions about handling colons
in filenames, so that prefixing file: would make it unambigious that the
colon is part of the file name and not a protocol name, but these days I
think we already have enough other ways to express this (the easiest
being ./test:foo, because protocols can't contain slashes)
Yes, but considering my first idea was to explicitly state the "file"
prefix instead of the simpler ./, maybe others think the same way. ;-)
Max
