On 28 February 2014 17:19, Richard Henderson <r...@twiddle.net> wrote: > On 02/26/2014 01:53 PM, Peter Maydell wrote: >> In QEMU we don't make any use at all of the common symbol >> functionality, so we can avoid this problem entirely simply >> by compiling with -fno-common. Enable this option for all >> builds, not just MacOSX, so that if we ever inadvertently >> introduce multiple definitions of some variable that will >> be immediately spotted as a build error rather than only >> breaking the MacOSX build. >> >> Suggested-by: Markus Armbruster <arm...@redhat.com> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > Reviewed-by: Richard Henderson <r...@twiddle.net>
Thanks. Applied to master as a MacOSX buildfix. -- PMM
