On 03/07/2014 06:20 AM, Romain Dolbeau wrote: > Signed-off-by: Romain Dolbeau <rom...@dolbeau.org> > --- > hw/net/e1000.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-)
> if (++s->eecd_state.bitnum_in == 9 && !s->eecd_state.reading) { > - s->eecd_state.bitnum_out = ((s->eecd_state.val_in & 0x3f)<<4)-1; > + s->eecd_state.bitnum_out = ((s->eecd_state.val_in & 0x3f) << 4)-1; If you're fixing operator spacing, why not also fix the spacing around binary '-' at the same time? > for (i = 0; i < 3; i++) { > - d->eeprom_data[i] = (macaddr[2*i+1]<<8) | macaddr[2*i]; > + d->eeprom_data[i] = (macaddr[2*i+1] << 8) | macaddr[2*i]; Likewise around * and + -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature