On Tue, Mar 11, 2014 at 09:20:55PM +0200, Marcel Apfelbaum wrote: > On Tue, 2014-03-11 at 19:51 +0100, Stefan Hajnoczi wrote: > > On Tue, Mar 11, 2014 at 03:00:34PM +0200, Marcel Apfelbaum wrote: > > > 'socket_accept' waits for Qemu to init its unix socket. > > > If Qemu encounters an error during command line parsing, > > > it can exit before initializing the communication channel. > > > > > > Using a timeout for sockets fixes the issue. > > > > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > > Signed-off-by: Marcel Apfelbaum <marce...@redhat.com> > > > --- > > > tests/libqtest.c | 13 +++++++++++-- > > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > > Thanks for the help, Stefan! > Please be aware that until you take care of the > "abort during qtest_init" issue, qtest will crash > on such occasions. > > Last thing, which maintainer should take this?
Andreas Färber is the most likely victim^H^H^H^H^H^Hmaintainer: "I don't feel like the official qtest maintainer, but I care and am actively working on it. I would consider it best to have individual tests maintained by subsystem maintainers and only define a maintainer for the core libqtest.c/qtest.c code." Although I'm interested in libqtest myself I don't have the bandwidth to review/merge all future patches in that area. Stefan
