On 13 March 2014 20:39, Andreas Färber <afaer...@suse.de> wrote: > Am 13.03.2014 15:17, schrieb Peter Maydell: >> When running under qtest we don't actually have any vcpu threads >> to be starved, so the warning about the I/O thread spinning isn't >> relevant, and the way qtest manipulates the simulated clock means >> the warning is produced a lot as a false positive. Suppress it if >> qtest_enabled(), so 'make check' output is less noisy. >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > [...] >> diff --git a/stubs/Makefile.objs b/stubs/Makefile.objs >> index df3aa7a..6f06fca 100644 >> --- a/stubs/Makefile.objs >> +++ b/stubs/Makefile.objs >> @@ -28,3 +28,4 @@ stub-obj-y += vmstate.o >> stub-obj-$(CONFIG_WIN32) += fd-register.o >> stub-obj-y += cpus.o >> stub-obj-y += kvm.o >> +stub-obj-y += qtest.o > [snip] > > Please note that the stubs are supposed to be sorted alphabetically.
OK. I looked at the tail end of the file (which as you can see is not in order) and thought we weren't trying to maintain an order here. I guess that's just previous commits also adding at the end of the file, though... thanks -- PMM
