On 03/14/2014 05:48 AM, Gerd Hoffmann wrote: > On Do, 2014-03-13 at 15:30 -0400, Cole Robinson wrote: >> First patch documents a configure option. >> Next 3 patches fix deprecation warnings on gtk 3.10. >> The remaining patches are bug fixes. >> >> v2: >> Add configure patch >> Fix building against GTK2 > > I'll go cherry-pick the two warp bugfixes (patches 6+7) for qemu 2.0. > > I'll leave the other cleanups for 2.1. The gtk2/3 compatibility isn't > that easy to get right it seems. Our current mimimal required gtk > version is 2.18, and on rhel6 (2.20) the build still fails: > > CC ui/gtk.o > In file included from /usr/include/gtk-2.0/gtk/gtk.h:233, > from ui/gtk.c:48: > /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function > declaration isn’t a prototype > ui/gtk.c: In function ‘gd_create_menu_machine’: > ui/gtk.c:1308: error: ‘GDK_KEY_q’ undeclared (first use in this > function) > ui/gtk.c:1308: error: (Each undeclared identifier is reported only once > ui/gtk.c:1308: error: for each function it appears in.) > make: *** [ui/gtk.o] Error 1 >
Hmm, thanks for testing. I didn't notice the GDK_KEY_foo back compat defines at the top of gtk.c, we need one for GDK_KEY_q as well. Would you prefer I wait until after 2.0 is out to resubmit the series? - Cole
