On 15 March 2014 18:33, Paolo Bonzini <pbonz...@redhat.com> wrote:
> Two missing braces, one close and one open, fabulously let the code
> compile.
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> target-alpha/translate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
> index a9ef1a7..e7e319b 100644
> --- a/target-alpha/translate.c
> +++ b/target-alpha/translate.c
> @@ -1927,6 +1927,7 @@ static ExitStatus translate_one(DisasContext *ctx,
> uint32_t insn)
> else {
> tcg_gen_neg_i64(cpu_ir[rc], cpu_ir[rb]);
> tcg_gen_ext32s_i64(cpu_ir[rc], cpu_ir[rc]);
> + }
> }
> }
> break;
> @@ -1991,7 +1992,7 @@ static ExitStatus translate_one(DisasContext *ctx,
> uint32_t insn)
> } else {
> if (islit)
> tcg_gen_movi_i64(cpu_ir[rc], -lit);
> - else
> + else {
> tcg_gen_neg_i64(cpu_ir[rc], cpu_ir[rb]);
> tcg_gen_ext32s_i64(cpu_ir[rc], cpu_ir[rc]);
> }
I'm surprised checkpatch didn't insist you added braces to the "if"
half of this if-else as well.
thanks
-- PMM
