On 03/21/2014 04:12 AM, Chunyan Liu wrote: s/repalce/replace/ in subject
Also, your overall series could probably use subject lines with a prefix that makes it obvious they are related to a common category; maybe "opts: ". > For later merge .create_opts of drv and proto_drv in qemu-img commands. > > Signed-off-by: Chunyan Liu <cy...@suse.com> > --- > + > +/* Realloc dst option list and append options either from an option list > (list) > + * or an QEMUOptionParameter (param) to it. dst could be NULL or a malloced > list. s/an QEMU/a QEMU/ > + * FIXME: will remove QEMUOptionParameter after all drivers switch to > QemuOpts. > + */ > +QemuOptsList *qemu_opts_append(QemuOptsList *dst, > + QemuOptsList *list, > + QEMUOptionParameter *param) > +{ > + size_t num_opts, num_dst_opts; > + QemuOptsList *tmp_list = NULL; > + QemuOptDesc *desc; > + bool need_init = false; > + > + assert(!(list && param)); > + if (!param &&!list) { Space after && -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature