Christopher Covington <c...@codeaurora.org> writes: > Hi Alex, > > Neat series. > > On 03/26/2014 10:37 AM, alex.ben...@linaro.org wrote: >> From: Alex Bennée <alex.ben...@linaro.org> >> >> When debugging big programs or system emulation sometimes you want both >> the verbosity of cpu,exec et all but don't want to generate lots of logs >> for unneeded stuff. This patch adds a new option -dfilter which allows >> you to specify interesting address ranges in the form: >> >> -dfilter 0x8000-0x9000,0xffffffc000080000+0x200,... >> >> Then logging code can use the new qemu_log_in_addr_range() function to >> decide if it will output logging information for the given range. >> > >> diff --git a/qemu-options.hx b/qemu-options.hx >> index ee5437b..a5cd095 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -2667,6 +2667,15 @@ STEXI >> Output log in @var{logfile} instead of to stderr >> ETEXI >> >> +DEF("dfilter", HAS_ARG, QEMU_OPTION_DFILTER, \ >> + "-dfilter range,.. filter debug output to range of addresses (useful >> for -d cpu,exec,etc..)\n", >> + QEMU_ARCH_ALL) > > It might be helpful to include a quick note in the documentation about the > format of range (based on your commit message and the code, I take it that > "a-b" means <a to b> while "a+b" means <a to a+b>).
Indeed. I shall try and update the relevant bits to make nice docs useful ;-) > > Thanks, > Christopher -- Alex Bennée