On 28 March 2014 17:37, Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > And while we are at it, since we pass &address_space_memory to all > occurences of virtio_*_phys() and I don't see why we would change > that, maybe we can also move that into the helpers. Thoughts ?
In the longer term I'm hoping that references to &address_space_memory go away -- we should be modelling separate address spaces per CPU and per every other thing that can act as a DMA master (ie issue memory transactions). I'm not sure exactly how virtio ought to work since these accesses directly to memory are a total hack, but probably we will end up setting the virtio device up and handing it an AddressSpace* that it should use. thanks -- PMM