On 04/02/2014 09:42 AM, Takashi Iwai wrote: > At Wed, 02 Apr 2014 09:28:54 -0400, > Cole Robinson wrote: >> >> On 04/02/2014 08:32 AM, Takashi Iwai wrote: >>> I simply like it better, you don't? :) >>> >> >> In fact, relative mouse mode is a pain without this feature, you need to >> manually initiate a grab with ctrl+alt+g before mouse movement will even >> work. >> Compare to our sdl front end, or virt-viewer, vinagre, virt-manager, where >> grab-on-click is the default (there isn't even an option to disable that >> behavior). >> >> I don't know what the original intention of the code was, but I think this >> behavior should be the default. Anthony, Gerd, thoughts? > > I noticed later that the original gtk-ui behavior is better when > vmmouse driver is available, i.e. the absolute mode is working. With > grab-on-click, you have to ungrab at each time you want to leave from > VM window. > > So I think we should leave the default behavior as is, since vmmouse > driver is likely available in most cases. But, still having this in > the menu makes our lives easier in case vmmouse isn't available or > doesn't work with QEMU. >
Or we just do what sdl.c does (and virt-viewer, and vinagre, and virt-manager): absolute mode == grab on hover, ungrab when pointer leaves the window relative mode == grab on click, require manual ungrab - Cole
