On 04/10/2014 08:43 AM, Eric Blake wrote: > On 04/10/2014 06:53 AM, Jeff Cody wrote: > >>>> +++ b/tests/qemu-iotests/common.rc >>>> @@ -178,10 +178,10 @@ _rm_test_img() >>>> local img=$1 >>> >>> Since we are quoting $img, should we quote $1 as well? >>>
> > http://austingroupbugs.net/view.php?id=351 > > But even with the notion of an assignment-context argument added to a > future version of POSIX, the reality is that given the present standard, > it's safer to either use "" to ensure no word splitting: Well, if you were trying to be portable to multiple shells, then it would matter. But as this script is explicitly being run under /bin/bash, and as bash already has support for declaration utilities where local is one such utility, your script as written is safe without "" in the arguments to local. So I'm fine whether you choose to change it in a respin or to leave it as written in this version. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
