Eric Blake writes: > On 04/13/2014 01:07 PM, Lluís Vilanova wrote: >> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> >> --- >> Makefile | 24 ++++++++++++++++++------ >> tests/Makefile | 20 ++++++++++++++++---- >> 2 files changed, 34 insertions(+), 10 deletions(-)
> Has this changed from v8? > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg01914.html > If not (or if the extent of the change was limited to the cosmetic issue > that I mentioned back then), it is wise to modify the commit message to > include the 'Reviewed-by' tag that I stuck there, so that I can quickly > tell that it is unchanged from the version I previously reviewed. >> $(patsubst %, check-%, $(check-qapi-schema-y)): check-%.json: >> $(SRC_PATH)/%.json >> - $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts $(PYTHON) >> $(SRC_PATH)/tests/qapi-schema/test-qapi.py <$^ >$*.test.out 2>$*.test.err; >> echo $$? >$*.test.exit, " TEST $*.out") >> + $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts \ >> + $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \ >> + <$^ \ >> + >$*.test.out \ >> + 2>$*.test.err; \ >> + echo $$? >$*.test.exit, \ > Nope, you didn't make the cosmetic change. At any rate, my review still > stands. > http://wiki.qemu.org/Contribute/SubmitAPatch mentions why it is > important to use Reviewed-by tags correctly to help speed up reviews of > subsequent revisions. Ok, I was not aware of that. I'll have that in mind for future contributions. Thanks. -- "And it's much the same thing with knowledge, for whenever you learn something new, the whole world becomes that much richer." -- The Princess of Pure Reason, as told by Norton Juster in The Phantom Tollbooth
